feat: Add implementation
state (amend)
#112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many RFCs are in a state where meaningful feedback only occurs once we start to implement them. So after we wrote it, asked for feedback etc.
We miss a forcing function for people to think about the problem to have a strong opinion about a topic.
This doesn't apply to every RFC, but it's a recurring theme, especially in SDKs and topics around APIs.
And I don't want to blame anyone here, I think this is mostly how people work - but I feel it's annoying and adds unnecessary friction.
The person driving RFCs also feels it when this happens that they haven't gotten any meaningful feedback yet.
That's why I am proposing to add a new RFC state called
implementation
FAQ:
Why can't it stay in
draft
?The RFC is still not approved so it's a draft, though the
implementation
state really is a forcing function for the author to move forward and also demonstrates more maturity than justdraft
Should we just have a sync meeting with the people involved to come to a conclusion?
Nothing beats actually writing the code and seeing where it falls short, sync meetings where everyone says LGTM won't solve it.
Can we create a Github Project or Workflow to cover this case instead?
That's too much complexity for everyone to keep track of and maintain.
Why are POCs not solving this?
POCs for changes are definitely welcome and help a lot but often are not enough to get feedback from different teams or people. Only when it gets serious and people make it their problem to solve they have opinions about it.
Will this new state fix my entire life?
No