Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add .NET/Portable-PDB specific protocol fields #1518

Merged
merged 6 commits into from
Oct 17, 2022

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Oct 6, 2022

This adds new fields to the Stack Frame and Debug Image protocol types, and expends the documentation on others.

The fields are specific to .NET symbolication using Portable PDB debug files.

RFC0013 introduces and explains these new fields.

This adds new fields to the Stack Frame and Debug Image protocol types, and expends the documentation on others.

The fields are specific to .NET symbolication using Portable PDB debug files.

[RFC0013](getsentry/rfcs#13) introduces and explains these new fields.
@Swatinem Swatinem marked this pull request as ready for review October 17, 2022 07:19
@Swatinem Swatinem requested a review from a team as a code owner October 17, 2022 07:19
@Swatinem Swatinem requested a review from a team October 17, 2022 07:19
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Swatinem Swatinem enabled auto-merge (squash) October 17, 2022 10:08
@Swatinem Swatinem merged commit b3dd24a into master Oct 17, 2022
@Swatinem Swatinem deleted the feat/dotnet-protocol branch October 17, 2022 12:21
jan-auer added a commit that referenced this pull request Oct 25, 2022
* master:
  release: 0.8.15
  fix(py): Respect the renormalize flag (#1548)
  (fix)e2e: Use report self hosted issues env variable (#1539)
  meta(vscode): Enable all features in Rust-Analyzer (#1542)
  release: 0.8.14
  build(craft): Fix manylinux artifact name (#1547)
  feat(quotas): New data category for indexed transactions (#1535)
  test(auth): Unflake re_auth_failure (#1531)
  replays: add warning log for parse errors (#1534)
  fix(server): Retain valid cached project states on error (#1426)
  feat(protocol): Implement response context schema (#1529)
  feat(replays): emit org_id on recording kafka messages (#1528)
  feat: Add .NET/Portable-PDB specific protocol fields (#1518)
  feat(quotas): Enforce rate limits on metrics buckets (#1515)
  ref(pii): Consider all token as sensitive [INGEST-1550] (#1527)
  release: 22.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants