fix: workaround for express.js 'host' deprecation message #413
Conversation
f2740e1
to
d1d7fe2
Compare
There was a problem hiding this comment.
This will fix the deprecation warning by express in first place by replacing 'host' by 'hostname' in nonEnumerables. However checking for 'hostname' using hasOwnProperty in the second place does not fix anything at all. Koajs (just to mention, because you made changes for also keeping that one intact) has both hostname and host aswell. Therefore your fix won't apply here.
| * REF: https://github.com/getsentry/raven-node/issues/96#issuecomment-354748884 | ||
| **/ | ||
| if (!request.hasOwnProperty('hostname')) { | ||
| sources.forEach(function(source) { |
There was a problem hiding this comment.
It's not because we want to keep correct order or eventual overrides – https://github.com/getsentry/raven-node/blob/master/lib/client.js#L229-L247
|
@AmazingTurtle in Koa |
Ref: #96 (comment)
Ref: #412