ref: disable flaky build retrying #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
force-pushed
the
asottile-failed-build
branch
2 times, most recently
from
02fe462
to
4b36f49
Compare
asottile-sentry
force-pushed
the
asottile-failed-build
branch
from
4b36f49
to
fe8e296
Compare
asottile-sentry
changed the title
billyvg
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getsentry.atlassian.net/browse/DEVINFRA-93
https://sentry.io/organizations/sentry/issues/3584516283/
github changed their url format at some point (I think this has been broken for over a year?) making the parsing for run id incorrect. I started fixing that and noticed that github now has 3 ids -- a run id, a job url id, and a job id. the urls are structured like
/actions/runs/<run id>/jobs/<job url id>-- the job url id is kinda useless as I can't seem to find its use in the api. the job id appears to be hiddenrather than rewriting the flakey detector, I'm opting to turn it off to get the slack notifications working again and we'll revisit whether we think the reruns are valuable