Changelog prerelease command fix #509
Conversation
| else if (!argv.noChangelog && config.preReleaseCommand && config.preReleaseCommand.length === 0) { | ||
| await commitNewVersion(git, newVersion); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Reading the code I think it would be better to always call commitNewVersion but update it to not hard error if there is nothing to commit. Earlier we ensure that the git status is clear before we start doing things, so we can trust that any changes that do now exist are supposed to be there.
There was a problem hiding this comment.
either way this should also have a test demonstrating what you're trying to accomplish. it's sorta unclear from the code change and topic and would be nice to ensure it doesn't regress from a future change
There was a problem hiding this comment.
We should also review the documentation.
|
This becomes urgent as we approach the next release, we'll hit the same issue in Vroom again otherwise. |
Adds a condition so that if preReleaseCommand is empty, but changelog changes still need to be committed, craft handles it