Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The item count DashBoards View displayed per page is not correct #5466

Closed
myonlylonely opened this issue Apr 9, 2021 · 13 comments · Fixed by #5516
Closed

The item count DashBoards View displayed per page is not correct #5466

myonlylonely opened this issue Apr 9, 2021 · 13 comments · Fixed by #5516

Comments

@myonlylonely
Copy link
Contributor

myonlylonely commented Apr 9, 2021 •
edited
Loading

Issue Summary

The item count DashBoards view displayed per page is not correct. By default, 20/page, but it actually shows only 12 items. If I switch to 5/page, it only shows 2 items. It can be reproduced on the deploy preview. https://redash-preview.netlify.app/dashboards?order=name&page=1&page_size=5

image

Technical details:

  • Redash Version: 9.0.0-beta (67263e1)
  • Browser/OS: Chrome 89.0.4389.114
  • How did you install Redash: Docker
@AkshayBz
Copy link

AkshayBz commented May 7, 2021

It's because of an issue with the all query. Haven't debugged the query yet, but here's why:

image

Presumably because of some join leading to extra rows in the query

@AkshayBz AkshayBz mentioned this issue May 7, 2021
Merged
4 tasks
@AkshayBz
Copy link

AkshayBz commented May 7, 2021

Found the root cause here: https://github.com/getredash/redash/pull/5267/files#r628401694

@susodapop
Copy link
Contributor

Hi there, I can't reproduce this on the latest tip of master.

@susodapop susodapop mentioned this issue Jun 14, 2021
Closed
@bratao
Copy link

bratao commented Jun 15, 2021

@susodapop I just tested the latest image on dockerhub ( redash:latest) and the bug is still present.

@susodapop
Copy link
Contributor

Thank you @bratao. I have reproduced it locally now. Working on a patch today.

susodapop added a commit that referenced this issue Jun 15, 2021
@susodapop
Add test that reproduces issue #5466
5ed241d
susodapop added a commit that referenced this issue Jun 15, 2021
@susodapop
Fix: Duplicate dashboard rows were returned by Dashboard.all() (#5466)
1f83f3b
@susodapop susodapop mentioned this issue Jun 15, 2021
Merged
1 task
@susodapop
Copy link
Contributor

@AkshayBz and @bratao would appreciate if can you try #5516 to confirm it resolves this bug for you. This is the only thing blocking the V10 beta 😃

@bratao
Copy link

bratao commented Jun 15, 2021

Thank you @susodapop , is ok to wait for Docker image (https://hub.docker.com/r/redash/redash/) to update to test it? I do not have a configured build env to do it.

arikfr pushed a commit that referenced this issue Jun 15, 2021
@susodapop
Fix: pagination is broken on the dashboard list page (#5516)
dec8879 
* Add test that reproduces issue #5466

* Fix: Duplicate dashboard rows were returned by Dashboard.all() (#5466)
@susodapop
Copy link
Contributor

Yes @bratao that's fine. The beta should go live in a few days.

susodapop added a commit that referenced this issue Jun 17, 2021
@susodapop
Fix: pagination is broken on the dashboard list page (#5516)
4cb0cc2 
* Add test that reproduces issue #5466

* Fix: Duplicate dashboard rows were returned by Dashboard.all() (#5466)
@AkshayBz
Copy link

@susodapop Same thing on my side, will try out as soon as new beta image is live. Thanks once again for the fix!

guerrerocarlos pushed a commit to MasterworksIO/redash that referenced this issue Jun 30, 2021
@susodapop @guerrerocarlos
Fix: pagination is broken on the dashboard list page (getredash#5516)
dfed316 
* Add test that reproduces issue getredash#5466

* Fix: Duplicate dashboard rows were returned by Dashboard.all() (getredash#5466)
@AkshayBz
Copy link

AkshayBz commented Jul 6, 2021

@susodapop Seems to be fixed on my end. 10.0.0-beta

@myonlylonely
Copy link
Contributor Author

Confirmed fixed in 10.0 beta

@myonlylonely
Copy link
Contributor Author

myonlylonely commented Aug 12, 2021 •
edited
Loading

It hasn't been merged into master branch. So the preview Docker image still has this issue.

@myonlylonely myonlylonely reopened this Aug 12, 2021
@susodapop
Copy link
Contributor

The tip of master is not guaranteed to be stable. Use the release branches. The fix will be merged into master once V10 is released.

susodapop added a commit that referenced this issue Oct 2, 2021
@susodapop
Fix: pagination is broken on the dashboard list page (#5516)
742db57 
* Add test that reproduces issue #5466

* Fix: Duplicate dashboard rows were returned by Dashboard.all() (#5466)
denisov-vlad pushed a commit to denisov-vlad/redash that referenced this issue Oct 19, 2021
Squashed commit of the following:
25d2578 
commit 9c928bd
Author: Jesse Whitehouse <[email protected]>
Date:   Fri Oct 1 21:13:13 2021 -0500

    Bump version to 10.0.0

commit f312adf
Author: Jesse <[email protected]>
Date:   Fri Oct 1 18:02:27 2021 -0500

    Apply V10 beta period feedback / fixes (getredash#5611)

    The following PR's were cherry-picked:

    * Excel & CSV query runner (getredash#2478)
    * Pin python3 image version (getredash#5570)
    * Fix: Edit Source button disappeared for users without CanEdit perms (getredash#5568)
    * Fix: Specify the protobuf version (getredash#5608)

    Plus one additional change exclusive to this branch:
    * Replace reference to yarn with NPM

    This happened because we cherry-picked getredash#5570 but did not also incorporate
    getredash#5541 into V10.

    Co-authored-by: deecay <[email protected]>
    Co-authored-by: Levko Kravets <[email protected]>
    Co-authored-by: zoomdot <[email protected]>

commit 92e5d78
Author: Jesse <[email protected]>
Date:   Thu Jun 17 13:42:07 2021 -0500

    Update changelog details for snowflake (getredash#5519)

commit 0983e69
Author: Jesse <[email protected]>
Date:   Thu Jun 17 12:45:17 2021 -0500

    update changelog for v10-beta (getredash#5517)

commit dec8879
Author: Jesse <[email protected]>
Date:   Tue Jun 15 15:04:36 2021 -0500

    Fix: pagination is broken on the dashboard list page (getredash#5516)

    * Add test that reproduces issue getredash#5466

    * Fix: Duplicate dashboard rows were returned by Dashboard.all() (getredash#5466)

commit 64a1d7a
Author: Jesse Whitehouse <[email protected]>
Date:   Tue Jun 1 11:21:49 2021 -0500

    Update version for CircleCI build.
susodapop added a commit that referenced this issue Oct 21, 2021
@susodapop
Fix: pagination is broken on the dashboard list page (#5612)
3c248ac 
* Fix: pagination is broken on the dashboard list page (#5516)
* Add test that reproduces issue #5466
* Fix: Duplicate dashboard rows were returned by Dashboard.all() (#5466)
* Update changelog for V10
* Update changelog for #5516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: pagination is broken on the dashboard list page getredash/redash
4 participants
@bratao @AkshayBz @myonlylonely @susodapop