Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): Decouple package lists from CLI #930

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 26, 2020

What does this change

What issue does it fix

Closes #908
Depends on getporter/packages#1

Notes for the reviewer

This is ready for initial review. Putting in draft to start as we're still waiting for the lists to exist in the canonical locations (e.g. https://cdn.porter.sh/mixins/index.json)

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@vdice vdice requested a review from carolynvs February 26, 2020 18:02
@vdice vdice marked this pull request as ready for review February 26, 2020 19:05
@vdice
Copy link
Member Author

vdice commented Feb 26, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

Signed-off-by: Vaughn Dice <[email protected]>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vdice vdice merged commit 283c437 into getporter:master Feb 26, 2020
@vdice vdice deleted the feat/decouple-package-list branch February 26, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: De-couple mixin search package directory from CLI
2 participants