Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why we need credential sets #916

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

carolynvs
Copy link
Member

What does this change

  • Add explanation for why we can define credential sources in porter.yaml from Slack to a new Q & A section on the Credentials page.
  • Rename the page to just "Credentials" to match how other pages are named and update references to the page, adding a redirect for the old name.
  • Fix whitespace on inline code blocks so they don't wrap

What issue does it fix

Get answers out of slack and into our docs

Notes for the reviewer

Make sure Carolyn didn't screw up please. 🙇‍♀

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@carolynvs carolynvs added this to In Progress in Porter and Mixins [OLD] via automation Feb 18, 2020
Add explanation for why we can define credential sources in porter.yaml
from Slack to a new Q & A section on the Credentials page.

Rename the page to just "Credentials" to match how other pages are named
and update references to the page, adding a redirect for the old name.

Fix whitespace on inline <code> blocks so they don't wrap
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Why can't the credential source be defined in porter.yaml?

The source of the credentials is specific to each installation of the bundle. An
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps The source of a credential is specific... or The sources of credentials are specific?

@carolynvs carolynvs merged commit 9c7bf1d into getporter:master Feb 18, 2020
Porter and Mixins [OLD] automation moved this from In Progress to Done Feb 18, 2020
@carolynvs carolynvs deleted the update-credentials branch February 18, 2020 20:30
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants