Generate unique helm test release names #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
361b5a0
to
811f23e
Compare
vdice
approved these changes
Feb 18, 2020
We accidentally were seeding with a constant, so the "random" release names we were generating for our tests actually were the same from test run to test run. Oops...
811f23e
to
6059a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
We accidentally were seeding with a constant, so the "random" release names we were generating for our tests actually were the same from test run to test run. Oops...
What issue does it fix
None, I saw this come up with the CI integration tests failed because it collided with a local integration test run.
Notes for the reviewer
Narp
Checklist