Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin tutorial #905

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Plugin tutorial #905

merged 2 commits into from
Feb 18, 2020

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Feb 14, 2020 •
edited

What does this change

Add tutorial for using plugins, based on the azure plugin.

https://deploy-preview-905--porter.netlify.com/plugins/tutorial/

What issue does it fix

None, it's a companion for a blog post that I'm working on.

Notes for the reviewer

I ❤️ docs

Checklist

  • Unit Tests
  • Documentation
    • Documentation Not Impacted

@carolynvs carolynvs added this to In Progress in Porter and Mixins [OLD] via automation Feb 14, 2020
@carolynvs carolynvs marked this pull request as ready for review February 14, 2020 18:22
@carolynvs carolynvs force-pushed the plugin-tutorial branch 3 times, most recently from e8b12a7 to d64ca8f Compare February 14, 2020 18:25
@carolynvs carolynvs mentioned this pull request Feb 14, 2020
Merged
vdice
vdice approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! LGTM.

(Maybe some day we can wrap most of the infra setup - creation/config of storage account/container and key vault - in a Porter bundle itself ✨ )

docs/content/plugin-tutorial.md Outdated

## Try it out

Let's try out Porter with the plugin activate and see it in action!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/activate/activated perhaps?

@carolynvs
Copy link
Member Author

As part of working with that Slack App I'm writing which cannot be named 😀 I have gotten a lot more familiar with Azure auth. At this point, I could update the plugin to use the credentials from az login and not need any env vars configured locally. If the creds have expired, the plugin could initiate sending you to the browser again to refresh them.

That way instead of authenticating to key vault or storage generically, it would be traceable back to the actual user running Porter.

@carolynvs
Copy link
Member Author

/azp run porter

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

/azp run porter

@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs merged commit 6be9a11 into getporter:master Feb 18, 2020
Porter and Mixins [OLD] automation moved this from In Progress to Done Feb 18, 2020
@carolynvs carolynvs deleted the plugin-tutorial branch February 18, 2020 19:54
@vdice vdice removed this from Done in Porter and Mixins [OLD] Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdice vdice vdice approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolynvs @vdice @carolynvs-msft