Add feature to mount host volumes #2949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This change adds flag --mount-host-volume for commands like porter install and porter uninstall, which enables making a host file system folder available inside the running container, which executes the action.
For example the following commands makes the host's $HOME/.hostfolder folder available inside the bundle (as read/write mount) at /home/nonroot/.hostfolder .
Multiple folders may be mounted. Format for adding a mount is <host path>:<container path>[:<option>]. If option is ro or not provided or invalid, then file system is mounted as read only. If option is rw then file system is mounted as read/write inside the container
What issue does it fix
Closes #475
Notes for the reviewer
This works with the docker driver. By default folders are mounted as read only.
Checklist
Reviewer Checklist