Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Dependencies: the LOGIC #2940

Merged
merged 46 commits into from
Dec 6, 2023

Conversation

schristoff
Copy link
Member

@schristoff schristoff commented Oct 9, 2023

Goal: If I have a parent bundle and a dependency, and that dependency already exists, don't install the dependency again, just wire them up together.

Things to note:

  • If child dependency exists, and sharing + group match, then on install we will get the arguments from the child dependency and give it to the parent when CNAB.execute is called. Child dependency won't be changed otherwise.
  • For pre-existing child dependencies, the following occurs:
    • Update: Updates to the parent are applied, the pre-existing child is not passed any update information
    • Invoke: This is for users to implement they want, but I'm leaving it as a foot gun. If you do an invoke and change the pre-existing child, then all other non-direct parents will need to be invoked as well. As in, we have no reconcile or logic to share these changes, do at your own risk.
    • Delete: For a pre-existing child, the parent is delete, the child is left. Users must delete the child manually.

Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
…-y curl did not complete successfully

Signed-off-by: schristoff <[email protected]>
… cleaned up desperately before debugging

Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: schristoff <[email protected]>
@schristoff schristoff marked this pull request as ready for review December 5, 2023 03:07
@schristoff schristoff changed the title [Draft]: Shared Dependencies: the LOGIC Shared Dependencies: the LOGIC Dec 5, 2023
Copy link
Contributor

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I only have documentation nits.

schristoff and others added 8 commits December 5, 2023 12:46
Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: Aaron Schlesinger <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly documentation feedback. I caught a couple spelling issues. I could have missed others, so might want to run through spellchecker.

Nice work!!

pkg/cnab/extended_bundle.go Outdated Show resolved Hide resolved
pkg/cnab/extended_bundle.go Outdated Show resolved Hide resolved
schristoff and others added 6 commits December 5, 2023 15:19
…dependencies.md

Co-authored-by: David Justice <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: David Justice <[email protected]>
Signed-off-by: schristoff <[email protected]>
…dependencies.md

Co-authored-by: David Justice <[email protected]>
Signed-off-by: schristoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]>
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀 🦄

Signed-off-by: Sarah Christoff <[email protected]>
@schristoff schristoff merged commit 716cd79 into getporter:main Dec 6, 2023
18 checks passed
@schristoff schristoff deleted the schristoff_depsresolvelogic branch December 6, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants