Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken contributing guide #2939

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

cmppoon
Copy link
Contributor

@cmppoon cmppoon commented Oct 9, 2023

What does this change

I fixed the Contributing Guide page by setting the type of the code blocks to bash, which resolved the formatting issue. I also moved the git commit command inside a code block to make the page more consistent.

What issue does it fix

Closes #2938

Notes for the reviewer

Please let me know if any changes are required.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Chaiyapruek Muangsiri <[email protected]>
@schristoff
Copy link
Member

Thank you so much for this contribution to our documentation :)

@schristoff schristoff merged commit 6c5683a into getporter:main Oct 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website: contributing guide looks broken
2 participants