Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v prefix #2890

Merged
merged 8 commits into from
Aug 31, 2023
Merged

add v prefix #2890

merged 8 commits into from
Aug 31, 2023

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Aug 29, 2023

What does this change

porter explain -r getporter/hello-llama:0.1.1 now prepends a v to the version (0.1.1), so that it will find the bundle if it is tagged v1.2.3 in the registry.

What issue does it fix

Closes #2886

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
@schristoff
Copy link
Member

Amazing work! Are you able to add some test cases for this?

@ludfjig
Copy link
Contributor Author

ludfjig commented Aug 29, 2023

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
@getporter getporter deleted a comment from azure-pipelines bot Aug 30, 2023
@getporter getporter deleted a comment from azure-pipelines bot Aug 30, 2023
pkg/porter/lifecycle.go Outdated Show resolved Hide resolved
Signed-off-by: Ludvig Liljenberg <[email protected]>
@schristoff schristoff merged commit a8fa983 into getporter:main Aug 31, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundles without "v"-tagged prefix cannot be pulled
2 participants