UnitTests fail on windows due to path formatting problems #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
changed the title
ludfjig
commented
Aug 4, 2023
jsturtevant
reviewed
Aug 5, 2023
| {"uninstall", "uninstall", "/home/myuser/.porter/mixins/exec/exec uninstall"}, | ||
| {"invoke", "status", "/home/myuser/.porter/mixins/exec/exec invoke --action status"}, | ||
| {"version", "version --output json", "/home/myuser/.porter/mixins/exec/exec version --output json"}, | ||
| {"build", "build", "/home/myuser/.porter/mixins/exec/exec build\n\\home\\myuser\\.porter\\mixins\\exec\\exec.exe build"}, |
There was a problem hiding this comment.
You can separate expected output by a newline character, so for this test there are two possible expected outputs which both pass
There was a problem hiding this comment.
oh interesting, might be easier to read if it is separated into array for the want command? maybe it isn't possible, not sure how the testing framework works.
| @@ -225,6 +224,11 @@ func TestPublish_RefreshCachedBundle(t *testing.T) { | |||
| require.NoError(t, err) | |||
| origBunPathTime := file.ModTime() | |||
|
|
|||
| if runtime.GOOS == "windows" { | |||
| // see https://github.com/getporter/porter/issues/2858 | |||
| time.Sleep(5 * time.Millisecond) | |||
|
Will you add a github job that runs the unit tests on prs? (Maybe as a follow up?) |
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AGMETEOR
pushed a commit
to AGMETEOR/porter
that referenced
this pull request
Aug 9, 2023
…2855) * (feat) Fix Unit Tests to pass on Windows Signed-off-by: Ludvig Liljenberg <[email protected]> --------- Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Lots of tests fail on windows because paths are hardcoded using forward slash, and never expects a volume such as "C:".
What issue does it fix
Closes #2854 but leaves #2858 for later
Checklist
Reviewer Checklist