Change printer for displayParam to display with list showing values like porter param show

[troy0820]

What does this change

Fixes the param list to show the output of the params and not just the name. The outputs for yaml and json show the params when queried and providing that functionality to fix the issue is why this fix is necessary.

What issue does it fix

Closes #2785

Notes for the reviewer

This can be up for discussion if we do not intend to fix this, this way

Checklist

• Did you write tests?
• Did you write documentation?
• Did you change porter.yaml or a storage document record? Update the corresponding schema file.
• If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

• Comment with /azp run test-porter-release if a magefile or build script was modified
• Comment with /azp run porter-integration if it's a non-trivial PR

[troy0820]

⇒ porter parameters show porter-hello
Name: porter-hello
Created: 1 hour ago
Modified: 1 hour ago

---------------------------------------------
  Name            Local Source  Source Type
---------------------------------------------
  mysql_user      fake-user     env
  wordpress-user  faker-user    env

⇒ porter parameters list porter-hello -o plaintext
-------------------------------------------------
  NAME            VALUE  STRATEGY    MODIFIED
-------------------------------------------------
  mysql_user      env    fake-user   1 hour ago
  wordpress-user  env    faker-user  1 hour ago

⇒ porter param list porter-hello -o plaintext
-------------------------------------------------
  NAME            VALUE  STRATEGY    MODIFIED
-------------------------------------------------
  mysql_user      env    fake-user   1 hour ago
  wordpress-user  env    faker-user  1 hour ago

[AGMETEOR]

Hey @troy0820 I hope I am allowed to add my review to this. This looks good and fixes the bug. I just noticed we could maybe also populate the Type column when we run porter parameters show

[troy0820]

Hey @troy0820 I hope I am allowed to add my review to this. This looks good and fixes the bug. I just noticed we could maybe also populate the Type column when we run porter parameters show

Yes, please any feedback is valuable. I noticed from the comment that the “strategy” could be TYPE which goes with what the other command shows.

I can change this to that

[troy0820]

Updated PR with tests to show p.PrintTableParameterSet in p.PrintParameters would satisfy the PR requirements

[AGMETEOR]

💯

[troy0820]

@schristoff Here is the issue #2836

I can work on that as well.

[schristoff]

/azp run porter-integration

[azure-pipelines]

No commit pushedDate could be found for PR 2824 in repo getporter/porter

[AGMETEOR]

#2836

@troy0820 do you mind if I take that off your hands?

[troy0820]

@AGMETEOR I think we want to talk about this in the community office hours. It's this week but I don't mind if you start with the initial implementation.

[AGMETEOR]

@AGMETEOR I think we want to talk about this in the community office hours. It's this week but I don't mind if you start with the initial implementation.

Could you kindly send me an invitation to #porter slack channel?

[troy0820]

https://getporter.org/community/

https://communityinviter.com/apps/cloud-native/cncf

[troy0820]

---------------------------------------------------
  NAMESPACE  NAME  TYPE    VALUE       MODIFIED
---------------------------------------------------
             foo   secret  foo_secret  1983-04-18

[troy0820]

-----------------------------------------------
  NAMESPACE  NAME  TYPE    VALUE   MODIFIED
-----------------------------------------------
             foo   secret  ******  1983-04-18

edited:
This is fixed to show the output being obfuscated if it is an "env" or a "secret" _(not using ResolvedValue)_. @AGMETEOR is handling the fix to be more global around params.

No bug on the name of the secret because the value is not shown as demonstrated in the porter params show command.

edited:

-----------------------------------------------
  NAMESPACE  NAME  TYPE    VALUE   MODIFIED
-----------------------------------------------
             foo   secret  foo_secret 1983-04-18

[troy0820]

Because issue #2836 is closed as the value of the secret is never shown but the name of the secret, there is no need to obfuscate the secret(s) when displaying the params list in json, yaml, or plaintext.

[schristoff]

ADO pipeline is still broken, this is an Azure issue, not a me issue. Just going to bypass and merge. :/