Do not pin invocation image to a specific debian release #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use stable instead of a specific debian release, so that when the release is archived, we don't end up with an unbuildable bundle. If a user wants to pin to a base image, they should use a custom Dockerfile. Porter should default to a release (stable) that will always work, so that porter doesn't need to be recompiled or a new version installed because a debian release was archived. Signed-off-by: Carolyn Van Slyck <[email protected]>
arschles
approved these changes
Apr 24, 2023
|
@arschles We don't need a specific base distribution for those tutorials, so I'm not sure why that documentation ever pointed to go 1.11 stretch specifically, vs just the go version. Honestly I just updated them so that if someone did a google search, they wouldn't find stuff that absolutely doesn't work anymore (stretch). But the tutorials aren't used or linked to and are kind of just around in case we reboot doing workshops about porter at conferences. |
|
How about just using the latest base image then? |
|
Yes, learn from your mistakes Carolyn. Don't pin stuff that doesn't need to be pinned. 😅 Fixing... |
Update the Porter workshop images to use golang:latest so that we don't need to keep updating it when it works just fine with any version of Go. Signed-off-by: Carolyn Van Slyck <[email protected]>
bdegeeter
pushed a commit
to bdegeeter/porter
that referenced
this pull request
May 11, 2023
) * Do not pin invocation image to a specific debian release Use stable instead of a specific debian release, so that when the release is archived, we don't end up with an unbuildable bundle. If a user wants to pin to a base image, they should use a custom Dockerfile. Porter should default to a release (stable) that will always work, so that porter doesn't need to be recompiled or a new version installed because a debian release was archived. Signed-off-by: Carolyn Van Slyck <[email protected]> * Use golang:latest for our (defunct) developer workshop Update the Porter workshop images to use golang:latest so that we don't need to keep updating it when it works just fine with any version of Go. Signed-off-by: Carolyn Van Slyck <[email protected]> --------- Signed-off-by: Carolyn Van Slyck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Use stable instead of a specific debian release, so that when the release is archived, we don't end up with an unbuildable bundle. If a user wants to pin to a base image, they should use a custom Dockerfile. Porter should default to a release (stable) that will always work, so that porter doesn't need to be recompiled or a new version installed because a debian release was archived.
What issue does it fix
Fixes #2744
Notes for the reviewer
N/A
Checklist
Reviewer Checklist