Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all "// +build" tags #2715

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Remove all "// +build" tags #2715

merged 1 commit into from
Apr 11, 2023

Conversation

hypernovasunnix
Copy link
Contributor

@hypernovasunnix hypernovasunnix commented Apr 10, 2023 •
edited
Loading

What does this change

Remove all old build tags

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Remove all // +build tags
6b45a93 
Signed-off-by: Sarah Christoff <[email protected]>
@carolynvs carolynvs self-assigned this Apr 11, 2023
carolynvs
carolynvs approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be so nice to not have my IDE constantly prompting about these. Thanks for the cleanup!

CONTRIBUTORS.md
@@ -79,3 +79,4 @@ and we will add you. **All** contributors belong here. 💯
* [Omar Kohl](https://github.com/omarkohl)
* [James Blair](https://github.com/jmhbnz)
* [Chengwei Guo](https://github.com/cw-Guo)
* [Sarah Christoff](https://github.com/hypernovasunnix)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@carolynvs
Copy link
Member

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs merged commit 937b99c into getporter:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolynvs carolynvs carolynvs approved these changes

@VinozzZ VinozzZ Awaiting requested review from VinozzZ

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees

@carolynvs carolynvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hypernovasunnix @carolynvs