Document how to implement mixin commands #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@jeremyrickard Let me know how this matched up to what you had to implement for the kubernetes mixin. |
|
That checks out pretty well. Couple of small comments inline |
| releases: | ||
| - porter-ci-mysql | ||
|
|
||
| # version |
There was a problem hiding this comment.
missing a close to the previous YAML block, so this doesn't get hyperlinked.
docs/content/mixin-commands.md
Outdated
|
|
||
| # status | ||
|
|
||
| The status command (required) is called from inside the invocation image during |
There was a problem hiding this comment.
status is an optional command isn't it?
|
Good catch, fixed! |
|
CI is stuck but the doc changes are in. Merging with my mega root. 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got excited and documented all the commands.
Closes #216
Preview available at https://deploy-preview-221--porter.netlify.com/mixin-commands/