Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.17 #1885

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Use Go 1.17 #1885

merged 1 commit into from
Feb 7, 2022

Conversation

carolynvs
Copy link
Member

What does this change

  • Update go.mod to the new 1.17 format
  • Update our build to use Go 1.17
  • Update docs to require Go 1.17
  • Ran go fmt to apply the new build tag format to all our files

What issue does it fix

N/A

Notes for the reviewer

None

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs carolynvs marked this pull request as ready for review February 2, 2022 15:06
@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Use Go 1.17
ff22659 
* Update go.mod to the new 1.17 format
* Update our build to use Go 1.17
* Update docs to require Go 1.17
* Ran go fmt to apply the new build tag format to all our files

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Member Author

There are CVE's on go 1.16, so I'm going to just merge this.

@carolynvs carolynvs merged commit f7767d0 into getporter:release/v1 Feb 7, 2022
@carolynvs carolynvs deleted the go-1.17 branch February 7, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@vdice vdice Awaiting requested review from vdice

@VinozzZ VinozzZ Awaiting requested review from VinozzZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@carolynvs