Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Flag Tipue Search as migrated #1296

Closed

Conversation

kdeldycke
Copy link
Contributor

@kdeldycke kdeldycke commented Aug 31, 2020

tipue_search plugin has been moved to its own repository. Add disclaimers in the same spirit as #1289 and #1292.

Relates to #1290.

Depends on pelican-plugins/tipue-search#1.

@kdeldycke kdeldycke changed the title Add disclaimer for migration of Tipue Search [Migration] Flag Tipue Search as migrated Dec 10, 2020
@kdeldycke
Copy link
Contributor Author

This plugin has been migrated, we can now merge this PR.

@justinmayer
Copy link
Member

So, the reason I have been holding off on moving forward with publishing the search plugin to PyPI relates to my previous comment on the topic.

@kdeldycke: Your response makes sense, but I think it’s predicated on a misunderstanding of what I meant. My only suggestion was that perhaps we could use a different name, leaving everything else the same. As background information, I wrote down a few related thoughts regarding plugin migration philosophy, which might shed more light on why I think this topic matters. Creating a separate repository and corresponding PyPI package for what will (hopefully) be a short-lived, point-in-time snapshot of a deprecated and unsupported plugin… It just doesn’t make a lot of sense to me.

Instead, what I would prefer to do might look something like this:

  • make the absolute minimum amount of changes needed to support the project name change
  • publish that code as v0.1
  • hopefully, eventually publish v1.0 based on a supported foundation

That was the intention behind my original proposal to change the name, which would avoid the previously-raised concerns:

  • blocking people searching for a working solution right now (Tipue Search plugin)
  • blocking people working on a better solution solution (lunr.js-based or other)
  • making plans about an ideal generic plugin, only to realize don’t have the manpower to implement them

To that end, I have pushed a new rename branch with the aforementioned minimal changes. I hope that it will simultaneously address my concerns about dragging around dead repos/packages while still allowing folks to have a working solution right now.

@kdeldycke: Would you have a look at the new branch and let me know what you think? I tried to use your blog site content and Plumage theme to test the renamed search plugin, but I ran into unrelated dependency conflicts and ultimately had to abort. I understand if you don’t have time to test out the new branch to ensure it works but would of course appreciate it if you don’t mind too much. 😅

@kdeldycke
Copy link
Contributor Author

Sorry @justinmayer for the late reply. Now that I backlogged the cross-comments, I have a better understanding of your proposal. So... let's do it! Let's merge your rename branch. Pretty sure it will work as-is. I'll test it later. Don't wait for me ! :)

@kdeldycke kdeldycke closed this by deleting the head repository Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants