refactor: remove redundant async signature

Resolves libp2p#4832 Pull-Request: libp2p#5468.
getong · Jun 18, 2024 · 0b1733d · 0b1733d
1 parent a8a4957
commit 0b1733d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/libp2p/CHANGELOG.md b/libp2p/CHANGELOG.md
@@ -9,6 +9,9 @@
 - Use `web-time` instead of `instant`.
  See [PR 5347](https://github.com/libp2p/rust-libp2p/pull/5347).
 
+- Remove redundant async signature from builder methods.
+ See [PR 5468](https://github.com/libp2p/rust-libp2p/pull/5468).
+
 ## 0.53.2
 
 - Allow `SwarmBuilder::with_bandwidth_metrics` after `SwarmBuilder::with_websocket`.

diff --git a/libp2p/src/builder/phase/dns.rs b/libp2p/src/builder/phase/dns.rs
@@ -8,8 +8,7 @@ pub struct DnsPhase<T> {
 
 #[cfg(all(not(target_arch = "wasm32"), feature = "async-std", feature = "dns"))]
 impl<T: AuthenticatedMultiplexedTransport> SwarmBuilder<super::provider::AsyncStd, DnsPhase<T>> {
- // TODO: Remove `async`
- pub async fn with_dns(
+ pub fn with_dns(
  self,
  ) -> Result<
  SwarmBuilder<

diff --git a/libp2p/src/builder/phase/other_transport.rs b/libp2p/src/builder/phase/other_transport.rs
@@ -73,7 +73,7 @@ impl<Provider, T: AuthenticatedMultiplexedTransport>
 impl<T: AuthenticatedMultiplexedTransport>
  SwarmBuilder<super::provider::AsyncStd, OtherTransportPhase<T>>
 {
- pub async fn with_dns(
+ pub fn with_dns(
  self,
  ) -> Result<
  SwarmBuilder<
@@ -82,7 +82,7 @@ impl<T: AuthenticatedMultiplexedTransport>
  >,
  std::io::Error,
  > {
- self.without_any_other_transports().with_dns().await
+ self.without_any_other_transports().with_dns()
  }
 }
 #[cfg(all(not(target_arch = "wasm32"), feature = "tokio", feature = "dns"))]

diff --git a/libp2p/src/builder/phase/quic.rs b/libp2p/src/builder/phase/quic.rs
@@ -150,7 +150,7 @@ impl<Provider, T: AuthenticatedMultiplexedTransport> SwarmBuilder<Provider, Quic
 }
 #[cfg(all(not(target_arch = "wasm32"), feature = "async-std", feature = "dns"))]
 impl<T: AuthenticatedMultiplexedTransport> SwarmBuilder<super::provider::AsyncStd, QuicPhase<T>> {
- pub async fn with_dns(
+ pub fn with_dns(
  self,
  ) -> Result<
  SwarmBuilder<
@@ -162,7 +162,6 @@ impl<T: AuthenticatedMultiplexedTransport> SwarmBuilder<super::provider::AsyncSt
  self.without_quic()
  .without_any_other_transports()
  .with_dns()
- .await
  }
 }
 #[cfg(all(not(target_arch = "wasm32"), feature = "tokio", feature = "dns"))]