Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for newer versions of Java in gradle #383

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

yanokwa
Copy link
Member

@yanokwa yanokwa commented Nov 16, 2018

What has been done to verify that this works as intended?

Ran ./gradlew clean jar and ensured I did not see Could not determine java version from '11.0.1'. error message.

Why is this the best possible solution? Were any other approaches considered?

Upgrades are needed and this is the only way.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect on users.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggalmazor ggalmazor merged commit b585f4d into getodk:master Nov 20, 2018
@yanokwa yanokwa deleted the upgrade-gradle branch March 8, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants