Deprecate validate methods with markCompleted parameter (#736)

src/jmh/java/org/javarosa/benchmarks/FormDefValidateBenchmark.java

@@ -58,7 +58,7 @@ public void initialize() throws IOException, XFormParser.ParseException {
 
  @Benchmark
  public void benchmarkFormDefValidate(FormDefValidateState state, Blackhole bh) {
- ValidateOutcome validateOutcome = state.formDef.validate(true);
+ ValidateOutcome validateOutcome = state.formDef.validate();
  bh.consume(validateOutcome);
  }
 }

src/main/java/org/javarosa/core/model/FormDef.java

@@ -721,6 +721,14 @@ public Collection<QuickTriggerable> triggerTriggerables(TreeReference ref) {
  return dagImpl.triggerTriggerables(getMainInstance(), getEvaluationContext(), ref);
  }
 
+ public ValidateOutcome validate() {
+ return validate(true);
+ }
+
+ /**
+ * @deprecated Use 'validate' without the 'markCompleted' parameter, as the 'true' value has been the only one used.
+ */
+ @Deprecated
  public ValidateOutcome validate(boolean markCompleted) {
 
  FormEntryModel formEntryModelToBeValidated = new FormEntryModel(this);

src/main/java/org/javarosa/core/model/TriggerableDag.java

@@ -406,6 +406,14 @@ void reportDependencyCycles() {
  * FormEntryController is based upon the FormDef, but has its own model and
  * controller independent of anything at the UI layer.
  */
+ public ValidateOutcome validate(FormEntryController formEntryControllerToBeValidated) {
+ return validate(formEntryControllerToBeValidated, true);
+ }
+
+ /**
+ * @deprecated Use 'validate' without the 'markCompleted' parameter, as the 'true' value has been the only one used.
+ */
+ @Deprecated
  public ValidateOutcome validate(FormEntryController formEntryControllerToBeValidated, boolean markCompleted) {
 
  formEntryControllerToBeValidated.jumpToIndex(FormIndex.createBeginningOfFormIndex());

src/test/java/org/javarosa/core/test/FormDefMatchers.java

@@ -26,7 +26,7 @@ public static TypeSafeMatcher<FormDef> valid() {
  return new TypeSafeMatcher<FormDef>() {
  @Override
  protected boolean matchesSafely(FormDef item) {
- return item.validate(true) == null;
+ return item.validate() == null;
  }
 
  @Override

src/test/java/org/javarosa/core/test/Scenario.java

@@ -168,7 +168,7 @@ public FormIndex getCurrentIndex() {
  }
 
  public ValidateOutcome getValidationOutcome() {
- return formDef.validate(true);
+ return formDef.validate();
  }
 
  /**