Prevent concurrent modification in the comparison cache

getodk · Feb 15, 2024 · 09a8a95 · 09a8a95
1 parent 63fedf8
commit 09a8a95
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/org/javarosa/core/model/ComparisonExpressionCacheFilterStrategy.java b/src/main/java/org/javarosa/core/model/ComparisonExpressionCacheFilterStrategy.java
@@ -56,7 +56,10 @@ public List<TreeReference> filter(@NotNull DataInstance sourceInstance, @NotNull
  }
  }
 
- private List<TreeReference> getCachedEvaluations(@NotNull Supplier<List<TreeReference>> next, String key) {
+ /**
+ * Synchronized to prevent two or more threads from modifying {@link #cachedEvaluations} at once
+ */
+ private synchronized List<TreeReference> getCachedEvaluations(@NotNull Supplier<List<TreeReference>> next, String key) {
  if (cachedEvaluations.containsKey(key)) {
  return cachedEvaluations.get(key);
  } else {