Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine form entry view model factories and convert QuitFormDialogFragment to simple dialog #5391

Merged
merged 13 commits into from
Mar 9, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Dec 30, 2022

Follow up to #5366 (discussion here and here)

What has been done to verify that this works as intended?

New and existing tests and verified manually.

Why is this the best possible solution? Were any other approaches considered?

Discussed in #5366

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This shouldn't change anything, but a lot of form entry code has been touched. I'd recommend checking form entry in general, but also:

  • deleting repeats
  • recording audio (for questions and in the background)
  • select one from map questions

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg force-pushed the view-model-factory branch 2 times, most recently from 3fb5b77 to c845216 Compare February 16, 2023 22:17
@seadowg seadowg mentioned this pull request Feb 21, 2023
3 tasks
@seadowg seadowg force-pushed the view-model-factory branch 2 times, most recently from 45c6a8a to 31a75f5 Compare February 23, 2023 18:27
@seadowg seadowg marked this pull request as ready for review February 23, 2023 18:44
@grzesiek2010 grzesiek2010 self-requested a review March 3, 2023 16:16
@dbemke
Copy link

dbemke commented Mar 9, 2023

Tested with Success!

Verified on Android 10

Verified Cases:
- switching to a different app during: Save/Ignore dialog, Permission dialogs, Hierarchy view
- background processing set to "No"
- don't keep activities enabled/disabled
- minimize the app, rotate the screen, lock the screen
- Select one map widgets
- restoring to the quit form dialog shows the hierarchy
- restoring to the hierarchy shows normal form entry instead of the hierarchy
- restoring in Edit Saved Form, View Sent Form
- regression checks in Restoring the app from the background when Form Entry dialogs displayed
- regression checks in forms with audio

@srujner
Copy link

srujner commented Mar 9, 2023

Tested with Success!

Verified on Android 12 and 13

@seadowg seadowg merged commit bdbee2d into getodk:master Mar 9, 2023
@seadowg seadowg deleted the view-model-factory branch March 9, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants