-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Updated at" subtext for forms that get updated attachments #5386
Conversation
4dcebd5
to
f5a9e55
Compare
collect_app/src/main/java/org/odk/collect/android/formmanagement/ServerFormDownloader.java
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/adapters/FormListAdapter.java
Show resolved
Hide resolved
ede0802
to
bae79c8
Compare
We have found one strange behavior related to the sorting. cc: @lognaturel |
This is something we didn't consider... I agree that it looks a bit strange and probably should be fixed. |
I think it'd make sense to use the "updated at" value if present for the sort so that the two marked forms in @srujner's example would appear at the top of the list. We can definitely merge (and I'd argue release) this as-is and write a new issue for updating sort, but happy to let you do it as part of this PR if you'd prefer to just get it done @grzesiek2010. Up to you! |
Ok let's have a separate issue for that. |
Great. Go ahead and continue testing then @getodk/testers. |
Tested with Success! Verified on Android 10 Verified Cases:
|
Tested with Success! Verified on Android 13 Found issues will be created in a separate issue |
Closes #5384
What has been done to verify that this works as intended?
I've verified the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
Not much to describe here... I've just updated the current implementation to display proper subtext.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
As described in the issue a proper subtext should be displayed in the list of forms (in both the list of forms to open and the list of forms to delete). Please test both lists to make sure it works as expected. I can't see any risk in other parts of the app. The description in the issue lists possible cases very well so please read.
Do we need any specific form for testing your changes? If so, please attach one.
Any form with attachments.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.