fix(docker): error in api healthcheck logic #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec24a8b
to
662ea79
Compare
jcrapuchettes
approved these changes
Jan 30, 2024
vincent-pochet
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working with Jeremy for a little while on a lago api-worker error, we realized that it was likely caused by a race condition on startup using the docker-compose.yml, when the worker started before the api migrations are finished. The
curlbinary was missing from the api image, which was recently resolved, and this PR points the the healthcheck at the/healthendpoint and uses thecondition: service_healthyto enforce that the lago api is healthy befor the lago services that depend on the api start.DO NOT MERGE this until the lago-api image is >
0.54.2-betabecause this depends the fix mentioned above!