Prevent Credit Note details from always displaying hardcoded USD #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A hardcoded USD currency is shown because accountCurrency is never fetched using GraphQL
ansmonjol
added a commit
that referenced
this pull request
Dec 29, 2023
Initially done in #1372 Co-Authored-By: Edward Poot <[email protected]>
ansmonjol
added a commit
that referenced
this pull request
Jan 2, 2024
Initially done in #1372 Co-Authored-By: Edward Poot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hardcoded USD currency is shown because accountCurrency is never fetched using GraphQL, this PR fixes this bug.
Context
Even if my credit note is in EUR, USD is shown for the item
Description
The issue is that the
amountCurrencyis used in the code to render the item, however it isn't fetched using GraphQL, defaulting to USD.See screenshot.