fix: Trial period set to zero should not be considered as present #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
added
Plan
jdenquin
reviewed
Dec 1, 2022
rsempe
reviewed
Dec 1, 2022
lovrocolic
approved these changes
Dec 1, 2022
rsempe
reviewed
Dec 1, 2022
vincent-pochet
force-pushed
the
fix-zero-trial-period
branch
from
8be241d
to
8c0f4bd
Compare
ansmonjol
reviewed
Dec 1, 2022
rsempe
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When setting a trial period at
0the first subscription of a paid in advance calendar plan is wrongly billed at 0 when created on the last day of the periodDescription
The issue is related to a wrong assumption of the behavior of the rails
present?method: