Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credit_notes): Improve credit note schema #633

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

vincent-pochet
Copy link
Collaborator

Roadmap Task

👉 getlago/lago#59

Context

The objective of this feature is to introduce a new concept of credit notes.

The main reason behind this need is to handle the following case:

  • If an overdue has been paid because a customer passes from a yearly plan to a monthly plan (in_advance), we charge the customer as if the remainder does not exist.

Description

This PR Improves the currently merged credit note features:

  • Adds a refunded_at fields to credit note
  • Removes refund_amount_cents and refund_amount_currency from credit note item
  • Renames credit_amount_cents and credit_amount_currency into amount_*

@vincent-pochet vincent-pochet added the Credit Note Related to Credit Note label Nov 29, 2022
@vincent-pochet vincent-pochet self-assigned this Nov 29, 2022
@vincent-pochet vincent-pochet changed the title feat(creadit_notes): Improve credit note schema feat(credit_notes): Improve credit note schema Nov 29, 2022
@vincent-pochet vincent-pochet merged commit 33a45b8 into main Nov 29, 2022
@vincent-pochet vincent-pochet deleted the ftr-credit-notes-items-migration branch November 29, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Credit Note Related to Credit Note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants