fix: Startup script does not always perform migrations #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-startup-script
branch
from
84a0765
to
4565340
Compare
jdenquin
approved these changes
Jul 5, 2024
ancorcruz
approved these changes
Jul 5, 2024
ancorcruz
pushed a commit
that referenced
this pull request
Jul 7, 2024
## Context This PR is a fix for #1945 (comment) ## Description Lago startup script is relying on the `rails db:migrate:primary` to perform the migration at startup. Since in some situation, only one database is configured in the `database.yml` file, the command is failing with the following error: ``` Unrecognized command "db:migrate:primary" (Rails::Command::UnrecognizedCommandError) Did you mean? db:migrate:up ``` This PR fixes this by using `rails db:migrate` instead when only one database is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a fix for #1945 (comment)
Description
Lago startup script is relying on the
rails db:migrate:primaryto perform the migration at startup.Since in some situation, only one database is configured in the
database.ymlfile, the command is failing with the following error:This PR fixes this by using
rails db:migrateinstead when only one database is present.