fix(analytics): Prevent fetching deleted customer analytics

getlago · Jul 12, 2024 · cb2c4a0 · cb2c4a0
1 parent 3faa193
commit cb2c4a0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/models/analytics/gross_revenue.rb b/app/models/analytics/gross_revenue.rb
@@ -8,7 +8,7 @@ class << self
  def query(organization_id, **args)
  if args[:external_customer_id].present?
  and_external_customer_id_sql = sanitize_sql(
- ['AND c.external_id = :external_customer_id', args[:external_customer_id]]
+ ["AND c.external_id = :external_customer_id AND c.deleted_at IS NULL", args[:external_customer_id]]
  )
  end
 

diff --git a/app/models/analytics/invoice_collection.rb b/app/models/analytics/invoice_collection.rb
@@ -8,7 +8,7 @@ class << self
  def query(organization_id, **args)
  if args[:external_customer_id].present?
  and_external_customer_id_sql = sanitize_sql(
- ["AND c.external_id = :external_customer_id", args[:external_customer_id]]
+ ["AND c.external_id = :external_customer_id AND c.deleted_at IS NULL", args[:external_customer_id]]
  )
  end
 

diff --git a/app/models/analytics/overdue_balance.rb b/app/models/analytics/overdue_balance.rb
@@ -8,7 +8,7 @@ class << self
  def query(organization_id, **args)
  if args[:external_customer_id].present?
  and_external_customer_id_sql = sanitize_sql(
- ["AND c.external_id = :external_customer_id", args[:external_customer_id]]
+ ["AND c.external_id = :external_customer_id AND c.deleted_at IS NULL", args[:external_customer_id]]
  )
  end