Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: homepage quick launch aka search #409

Merged
merged 12 commits into from
Oct 21, 2022
Merged

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Oct 19, 2022

I made a thing! Its a "quick launcher"? aka global search of all services & bookmarks, triggered by just typing on the page. Its very simple but as a result its fast AF. Im sure I missed some things in here but overall pretty happy with this. Appreciate any feedback / tweaks. Video is all keyboard =)

Edit:

  • A way to bring this up on mobile, or keep it desktop only?
  • Should we search / include descriptions?
  • Prioritization?
    • Edit: uses same order as services/bookmarks config, I think thats good
  • Highlighting?
homepagesearch.mov

Screen Shot 2022-10-19 at 8 19 29 PM

@shamoon shamoon changed the title Feature: homepage search Feature: homepage quick launch Oct 19, 2022
@shamoon shamoon changed the title Feature: homepage quick launch Feature: homepage quick launch aka search Oct 19, 2022
@nimodius
Copy link

This seems awesome, very useful! Cani test it somehow?

@shamoon
Copy link
Collaborator Author

shamoon commented Oct 19, 2022

This seems awesome, very useful! Cani test it somehow?

Good question! I think you'd need to pull the repo but its pretty easy if you want to try.

Regarding including descriptions, curious on people's thoughts. I have an (uncommitted) change that:

  • searches the description and shows highlighting only in the description to make it apparent why that result is included
  • prioritizes name matches ahead of description matches

See screenshot, again, would love to hear what people think 🙂
Screen Shot 2022-10-19 at 3 25 07 PM

@Facinorous-420
Copy link
Contributor

Facinorous-420 commented Oct 19, 2022

This seems awesome, very useful! Cani test it somehow?

Good question! I think you'd need to pull the repo but its pretty easy if you want to try.

Regarding including descriptions, curious on people's thoughts. I have an (uncommitted) change that:

  • shows the description
  • searches the description and shows highlighting only in the description to make it apparent why that result is included
  • prioritizes name matches ahead of description matches

See screenshot, again, would love to hear what people think 🙂>

This looks really nice Im going to pull this branch and try it out!
I like it showing the description, but I don't know how I feel about it also searching the description.

@shamoon
Copy link
Collaborator Author

shamoon commented Oct 20, 2022

This looks really nice Im going to pull this branch and try it out! I like it showing the description, but I don't know how I feel about it also searching the description.

Thanks! 😊 Yea I think I agree, I added them without searching, for now.

@nimodius
Copy link

I did try it and I think it works great, would love to have this. Once I used it a little I found myself missing it =)

Perhaps searching descriptions could be a setting, though only if many would use it (I dont think I would)

src/pages/index.jsx Outdated Show resolved Hide resolved
@shamoon shamoon force-pushed the feature-homepage-search branch 2 times, most recently from 9ac8a9e to dcecd57 Compare October 20, 2022 18:26
@shamoon
Copy link
Collaborator Author

shamoon commented Oct 20, 2022

Okey-dokey I added an option for searching descriptions (defaults to off), e.g.

quicklaunch:
    searchDescriptions: true

Screen Shot 2022-10-20 at 11 00 17 AM

vs

Screen Shot 2022-10-20 at 11 26 43 AM

and everybody wins =)

(note the first three items stay higher on the list because they matched the actual name)

@nimodius
Copy link

Okey-dokey I added an option for searching descriptions (defaults to off), e.g.

Yes I think this is a good solution for all. Hope to have this feature soon very soon!

@benphelps benphelps merged commit f7c5f88 into main Oct 21, 2022
@shamoon shamoon deleted the feature-homepage-search branch October 24, 2022 05:30
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants