-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: stock market service and info widget #3617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great overall and I think people will be happy with it. Especially like that its extensible.
A couple small things before I double-check the code is that as-is this will allow duplicates in the list (thats prob OK, people can do crazy things, then again it'd be easy enough to solve) but Im also wondering if the limit of 30 (which I know comes from the API) is too much. It just starts to get too large. Maybe thats OK but my gut tells me we should trim it down. What do you think?
I appreciate your feedback!
I will take care of this.
Agreed. A max of 6 kind of feels like the sweet spot. With a known max, I would also like to handle some viewport sizes a little differently. If it works, I can have these updates included tomorrow. If there is anything else that looks like it could be improved, I am happy to make the changes. |
Yea no problem, sounds good on all accounts. I’ll take a look at the code more closely after you push the changes but overall seems like pretty a clean PR thanks 👍 |
Yay! Love this! |
I could do both. The component looks like it is pretty easily adaptable: @shamoon What are your thoughts? Would it be better to pick one? Or would it be reasonable to have both component types as potential options? |
It's not clear from the FR if people want a service widget or info, so it's of course debatable. But given this is closest to the CoinMarketCap widget (which btw is better suited to the list format) perhaps that is the better way to go, sorry for the changeup. |
Happy to make the change. I agree that the format of the CoinMarketCap widget does work better overall. I can get started later today. |
I think both should be options. On the layout of the info widget, I think keeping the font size the same, and lowering the opacity of the price, would be more inline with the Homepage design direction. This would also allow it to use slightly less vertical space. |
For my personal use, I do prefer having a few items in the header in most instances.
I will look into these changes. Thanks for the tips. Apologies for the delay. I have been busy with work :) I was testing some other APIs to see if it makes sense to include them in the widget, but I think, at least for now, Finnhub seems like a better option with their free tier and limits. I also have tested getting data from I suggested this could be a |
I would just focus on this version, especially given it will now support two versions of the widget let’s keep the PR focused ie MVP. I’m confident this can be adapted for other APIs if there is need |
2008e5f
to
878d62b
Compare
Looking good. Small thing, I wouldn’t bother with displaying (or translating) the errors or displaying things like has duplicates, it’s basically a config error so just throw an error with details in the log and / or truncate the list / remove the duplicates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I havent tested yet, just some thoughts looking at the code. Thanks
Reviewing now. Thank you for these great suggestions. I will try and get them all added today. |
ran pre-commit hook improved translations and error handling include service widget fix: update docs image use original spacing in yaml file fix: typo in docs use Error component use regular error messaging here fix: make use of standard config error fix: map through data in jsx fix: simplify parsing/error logic
878d62b
to
ae3df9e
Compare
Mentioned issues should be resolved: https://github.com/gethomepage/homepage/compare/878d62b1f832f17bb57d18ac3b00ad70dec0c2df..ae3df9eeeb045f256bce33751d1d504ca96cf6cd I really appreciate the feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add crypto? |
Proposed change
Hello!
I have been working on an implementation of a stock market widget.
Relevant Feature Request - #297
Type of change
Checklist:
Notes
Desktop
Mobile