Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon move #3302

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Carbon move #3302

merged 2 commits into from
Apr 15, 2024

Conversation

benphelps
Copy link
Member

Proposed change

Move carbon ad placement to the side navigation

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

under the left side on non-widget doc pages, right side otherwise
@shamoon shamoon enabled auto-merge (squash) April 15, 2024 19:20
@shamoon shamoon merged commit 60098d3 into main Apr 15, 2024
3 checks passed
@shamoon shamoon deleted the carbon-move branch April 15, 2024 19:20
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants