Enhancement: allow api auth with moonraker service

[stevendejongnl]

Proposed change

Changed the genericProxyHandler to use the credentialedProxyHandler for moonraker instances that uses authorization by API keys.
With the genericProxyHandler you get a 401 unauthorized error on those instances.

Type of change

• Bug fix (non-breaking change which fixes an issue)

[shamoon]

Please provide an explanation and or / link to a discussion, even if the change seems obvious. It doesn’t seem any other moonraker users have asked about auth

[stevendejongnl]

Please provide an explanation and or / link to a discussion, even if the change seems obvious. It doesn’t seem any other moonraker users have asked about auth

Sorry, I submitted to quickly.
Updated the description

[shamoon]

Thanks. So moonraker api uses

homepage/src/utils/proxy/handlers/credentialed.js

Line 69 in 36585a2

headers["X-API-Key"] = `${widget.key}`;

?

[shamoon]

Also, thing to check here is that it won’t break non-auth instances…

(also assuming it never allows basic auth, which this would also break)

[stevendejongnl]

Thanks. So moonraker api uses

homepage/src/utils/proxy/handlers/credentialed.js

Line 69 in 36585a2

headers["X-API-Key"] = `${widget.key}`;

?

Thats correct:
https://moonraker.readthedocs.io/en/latest/web_api/#authorization

Also, thing to check here is that it won’t break non-auth instances…

(also assuming it never allows basic auth, which this would also break)

Good point, I will spin up another instance without authentication to check this.

[shamoon]

Great thanks. Yea as you can guess I don’t have an instance to test.

Thanks for the docs link, yea in this case please update the homepage docs to note the optional key parameter

[stevendejongnl]

Great thanks. Yea as you can guess I don’t have an instance to test.

Thanks for the docs link, yea in this case please update the homepage docs to note the optional key parameter

I can confirm that an instance without authentication and no key set in the configuration does work:

[shamoon]

Thanks for confirming that.

I don't really think this is a bug but since it literally adds 0 code thats cool. Do try to mind the PR requirements (checkboxes you removed) in the future (here and in general).

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.