Enhancement: extend hdhomerun widget #2757

JeffRandall · 2024-01-26T06:18:53Z

Proposed change

maintain the previous behavior if no new configuration is done
define additional available fields and present the data in order configured
- global: "tunerCount"
- per-tuner: "channelNumber", "channelNetwork", "signalStrength", "signalQuality", "symbolQuality", "networkRate", "clientIP"
add handling for refreshInterval
update docs

An example of two instances of the widget with the fields configured to be fields: [ "channels", "hd", "tunerCount" ] and fields: [ "clientIP", "channelNumber", "channelNetwork", "signalQuality" ] respectively:

Closes #772

Type of change

New service widget
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation only
Other (please explain)

Checklist:

If applicable, I have added corresponding documentation changes.
If applicable, I have reviewed the feature and / or service widget guidelines.
I have checked that all code style checks pass using pre-commit hooks and linting checks.
If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

- maintain the previous behavior if no additional configuration is done - define additional available fields and present the data in order configured - global: "tunerCount" - per-tuner: "channelNumber", "channelNetwork", "signalStrength", "signalQuality", "symbolQuality", "networkRate", "clientIP" - add handling for refreshInterval - update docs

shamoon

Thanks, this needs a bit of work.

Please also provide sample data for status.json

docs/widgets/services/hdhomerun.md

src/widgets/hdhomerun/component.jsx

public/locales/en/common.json

docs/widgets/services/hdhomerun.md

- Move the tuner directive into the widget entry

…uner directive to be part of the widget

JeffRandall · 2024-01-26T15:07:19Z

Sample status.json from a two tuner hdhomerun:

[ { "Resource": "tuner0", "VctNumber": "15.3", "VctName": "TBD", "Frequency": 581000000, "SignalStrengthPercent": 100, "SignalQualityPercent": 77, "SymbolQualityPercent": 100, "TargetIP": "10.11.2.10", "NetworkRate": 1764320 }, { "Resource": "tuner1" } ]

shamoon

Thanks for the changes, almost there =)

src/widgets/hdhomerun/component.jsx

docs/widgets/services/hdhomerun.md

src/widgets/hdhomerun/component.jsx

docs/widgets/services/hdhomerun.md

shamoon

Great thanks for making all the changes

…0.8.7@06203a4 by renovate (#17670) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.6` -> `v0.8.7` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7) #### What's Changed - Feature: Added gatus uptime widget by [@Nedra1998](https://togithub.com/Nedra1998) in [gethomepage/homepage#2729 - Fix: iCal integration use event data hash instead of unstable uid by [@shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2758 - Enhancement: extend hdhomerun widget by [@JeffRandall](https://togithub.com/JeffRandall) and [@shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2757 #### New Contributors - [@Nedra1998](https://togithub.com/Nedra1998) made their first contribution in [gethomepage/homepage#2729 - [@JeffRandall](https://togithub.com/JeffRandall) made their first contribution in [gethomepage/homepage#2757 **Full Changelog**: gethomepage/homepage@v0.8.6...v0.8.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

…0.8.7@06203a4 by renovate (truecharts#17670) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.6` -> `v0.8.7` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> [`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7) - Feature: Added gatus uptime widget by [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) in [gethomepage/homepage#2729 - Fix: iCal integration use event data hash instead of unstable uid by [@&truecharts#8203;shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2758 - Enhancement: extend hdhomerun widget by [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) and [@&truecharts#8203;shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2757 - [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) made their first contribution in [gethomepage/homepage#2729 - [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) made their first contribution in [gethomepage/homepage#2757 **Full Changelog**: gethomepage/homepage@v0.8.6...v0.8.7 </details> --- 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

…0.8.7@06203a4 by renovate (truecharts#17670) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage) | patch | `v0.8.6` -> `v0.8.7` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary> ### [`v0.8.7`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.7) [Compare Source](https://togithub.com/gethomepage/homepage/compare/v0.8.6...v0.8.7) #### What's Changed - Feature: Added gatus uptime widget by [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) in [gethomepage/homepage#2729 - Fix: iCal integration use event data hash instead of unstable uid by [@&truecharts#8203;shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2758 - Enhancement: extend hdhomerun widget by [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) and [@&truecharts#8203;shamoon](https://togithub.com/shamoon) in [gethomepage/homepage#2757 #### New Contributors - [@&truecharts#8203;Nedra1998](https://togithub.com/Nedra1998) made their first contribution in [gethomepage/homepage#2729 - [@&truecharts#8203;JeffRandall](https://togithub.com/JeffRandall) made their first contribution in [gethomepage/homepage#2757 **Full Changelog**: gethomepage/homepage@v0.8.6...v0.8.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

github-actions · 2024-02-26T03:05:28Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

shamoon changed the title ~~discussion #772: Extend the hdhomerun widget~~ Enhancement: extend hdhomerun widget Jan 26, 2024

shamoon requested changes Jan 26, 2024

View reviewed changes

JeffRandall added 3 commits January 26, 2024 08:48

- Revert inadvertent change to the "Learn more about" line

271f627

- Move the tuner directive into the widget entry

Correct indentation by converting tabs to spaces

a7b75e9

- Update the whitelisted keys for the hdhomerun widget and move the t…

91bf437

…uner directive to be part of the widget

shamoon requested changes Jan 26, 2024

View reviewed changes

JeffRandall added 2 commits January 26, 2024 11:52

Add missing quote mark

82c5627

Remove ability to configure field order to match project code convention

d705ed0

shamoon enabled auto-merge (squash) January 26, 2024 18:54

shamoon reviewed Jan 26, 2024

View reviewed changes

docs/widgets/services/hdhomerun.md Outdated Show resolved Hide resolved

Update docs/widgets/services/hdhomerun.md

d0cabac

shamoon approved these changes Jan 26, 2024

View reviewed changes

shamoon merged commit 05a7c0f into gethomepage:main Jan 26, 2024
5 checks passed

discretizer pushed a commit to discretizer/homepage that referenced this pull request Jan 28, 2024

Enhancement: extend hdhomerun widget (gethomepage#2757)

1ab3ea3

discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024

Enhancement: extend hdhomerun widget (gethomepage#2757)

4379c5a

discretizer pushed a commit to discretizer/homepage that referenced this pull request Feb 6, 2024

Enhancement: extend hdhomerun widget (gethomepage#2757)

582bc16

Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024

Enhancement: extend hdhomerun widget (gethomepage#2757)

74859fe

Plancke pushed a commit to Plancke/homepage that referenced this pull request Feb 23, 2024

Enhancement: extend hdhomerun widget (gethomepage#2757)

366385c

github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement: extend hdhomerun widget #2757

Enhancement: extend hdhomerun widget #2757

JeffRandall commented Jan 26, 2024 •

edited by shamoon

Loading

shamoon left a comment

JeffRandall commented Jan 26, 2024

shamoon left a comment

shamoon left a comment

github-actions bot commented Feb 26, 2024

Enhancement: extend hdhomerun widget #2757

Enhancement: extend hdhomerun widget #2757

Conversation

JeffRandall commented Jan 26, 2024 • edited by shamoon Loading

Proposed change

Type of change

Checklist:

shamoon left a comment

Choose a reason for hiding this comment

JeffRandall commented Jan 26, 2024

shamoon left a comment

Choose a reason for hiding this comment

shamoon left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2024

JeffRandall commented Jan 26, 2024 •

edited by shamoon

Loading