Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GameDig widget missing lib #1811

Merged
merged 19 commits into from
Aug 15, 2023
Merged

Fix: GameDig widget missing lib #1811

merged 19 commits into from
Aug 15, 2023

Conversation

fredodiable
Copy link
Contributor

Proposed change

Fixed GameDig widget Error: Cannot find module './lib/freeze'
Closes #1795

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (please explain)

Checklist:

  • If adding a service widget or a change that requires it, I have added a corresponding PR to the documentation here:
  • If adding a new widget I have reviewed the guidelines.
  • If applicable, I have checked that all tests pass with e.g. pnpm lint.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon
Copy link
Collaborator

shamoon commented Aug 13, 2023

Yea this is what I was planning to play with, thanks for looking into it. It is a bit hack-y, but I suppose at this point new versions of compressjs are unlikely

I think the branch needs a rebase and maybe revert the lockfile changes, but I can test it out soon

@fredodiable
Copy link
Contributor Author

For info, I was getting the same above error before editing the .dockerignore file
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum

@shamoon
Copy link
Collaborator

shamoon commented Aug 14, 2023

Yea, the problem with workarounds…

I’m far from knowledgeable when it comes to docker, but this isn’t building for me locally either. And failing on ci is of course a deal-breaker too

@fredodiable
Copy link
Contributor Author

Yea, the problem with workarounds…

I’m far from knowledgeable when it comes to docker, but this isn’t building for me locally either. And failing on ci is of course a deal-breaker too

What is your error message ?
Can you share your build command ?
It's building fine for me on Windows

@shamoon
Copy link
Collaborator

shamoon commented Aug 14, 2023

DOCKER_BUILDKIT=1 docker build -t homepage:local .

...
 => ERROR [builder 4/5] COPY . .                                2.2s
------
 > [builder 4/5] COPY . .:
------
cannot copy to non-directory: /var/lib/docker/overlay2/mddclqnjnwc1ol4edgnhcsdm0/merged/app/node_modules/@eslint/eslintrc

But again, not working on ci here either...

@fredodiable
Copy link
Contributor Author

After some trials and errors, finally managed to fix docker build

@shamoon
Copy link
Collaborator

shamoon commented Aug 15, 2023

Awesome mate, thanks

@shamoon shamoon merged commit 583494f into gethomepage:main Aug 15, 2023
1 check passed
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] GameDig widget Error: Cannot find module './lib/freeze'
2 participants