Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Service discovery #343

Closed
Cinj216 opened this issue Oct 6, 2022 · 4 comments
Closed

[Bug] Service discovery #343

Cinj216 opened this issue Oct 6, 2022 · 4 comments

Comments

@Cinj216
Copy link

Cinj216 commented Oct 6, 2022

Describe the bug
Service discovery grabs any label that has the word "homepage" and creates an erroneous blank entry for that container.

Expected behavior
For this to not happen.

Screenshots
Container grabbed by Service Discovery displayed at top of page:
Screenshot_20221006_132437

Container I actually set up further down the page (to demonstrate it's the same container):
Screenshot_20221006_132451

Labels the container applies to itself creating the problem:
Screenshot_20221006_132515

Configuration
Likely irrelevant.

Additional context
I have no control over the container labelling itself with it's homepage url so there's nothing I can do on my end to fix this. Homepage should ignore improperly formatted labels such as this or use a different labelling scheme that won't be likely to cause such a conflict. For whatever reason, this only started occurring today; previous versions didn't exhibit this behavior.

@benphelps
Copy link
Member

Oh that's very interesting, thank you for the report.

We'll try to get this fixed by the next release.

@Cinj216
Copy link
Author

Cinj216 commented Oct 6, 2022

Oh that's very interesting, thank you for the report.

We'll try to get this fixed by the next release.

I edited with one additional detail right as you replied, not sure if you caught it so I'll paraphrase it here. It only started occurring with the latest version, if that helps narrow down where the problem is. Thanks for your time.

benphelps added a commit that referenced this issue Oct 8, 2022
@benphelps
Copy link
Member

benphelps commented Oct 9, 2022

This should be fixed now, if not and you still find issues, feel free to reopen.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants