Skip to content

Commit

Permalink
Issue with dotnext PVC preventing normal deployments
Browse files Browse the repository at this point in the history
* fixed k3d-deploy.sh directory reference
  • Loading branch information
jameswynn committed Jan 18, 2023
1 parent b724f52 commit 725189a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
3 changes: 2 additions & 1 deletion k3d/Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ helm_resource('homepage', 'jameswynn/homepage',
],
# image_selector= "k3d-registry.localhost:55000/homepage:local",
flags=[
"-f", "k3d-helm-values.yaml"
"-f", "k3d-helm-values.yaml",
"--set", "persistence.dotnext.enabled=true"
]
)
2 changes: 1 addition & 1 deletion k3d/k3d-deploy.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

DOCKER_BUILDKIT=1 docker build -t k3d-registry.localhost:55000/homepage:local .
DOCKER_BUILDKIT=1 docker build -t k3d-registry.localhost:55000/homepage:local ..
docker push k3d-registry.localhost:55000/homepage:local

HELM_REPO_NAME=jameswynn
Expand Down
7 changes: 4 additions & 3 deletions k3d/k3d-helm-values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
image:
repository: k3d-registry.localhost:55000/homepage
tag: local
pullPolicy: IfNotPresent
pullPolicy: Always

config:
bookmarks:
Expand Down Expand Up @@ -68,9 +68,10 @@ ingress:
pathType: Prefix

persistence:
# this persists the .next directory which greatly improves successive pod startup times
# this persists the .next directory which greatly improves successive pod startup times in Tilt,
# but it breaks normal deployments, so it is disabled by default
dotnext:
enabled: true
enabled: false
type: pvc
accessMode: ReadWriteOnce
size: 1Gi
Expand Down
2 changes: 1 addition & 1 deletion k3d/k3d-up.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ chmod 600 kubeconfig
export KUBECONFIG=$(pwd)/kubeconfig

echo "Waiting for traefik install job to complete (CTRL+C is safe if you're impatient)"
kubectl wait jobs/helm-install-traefik -n kube-system --for condition=complete --timeout 90s && echo "Completed" || echo "Timed out"
kubectl wait jobs/helm-install-traefik -n kube-system --for condition=complete --timeout 90s && echo "Completed" || echo "Timed out (but it should still come up eventually)"

0 comments on commit 725189a

Please sign in to comment.