Add default method for setOptionalConfig in Plugin

gerashegalov · Jul 20, 2015 · bf49106 · bf49106
1 parent 6cc8cb5
commit bf49106
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 37 deletions.
diff --git a/presto-blackhole/src/main/java/com/facebook/presto/plugin/blackhole/BlackHolePlugin.java b/presto-blackhole/src/main/java/com/facebook/presto/plugin/blackhole/BlackHolePlugin.java
@@ -22,7 +22,6 @@
 import javax.inject.Inject;
 
 import java.util.List;
-import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -31,11 +30,6 @@ public final class BlackHolePlugin
 {
  private TypeManager typeManager;
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Inject
  public void setTypeManager(TypeManager typeManager)
  {

diff --git a/presto-ml/src/main/java/com/facebook/presto/ml/MLPlugin.java b/presto-ml/src/main/java/com/facebook/presto/ml/MLPlugin.java
@@ -24,7 +24,6 @@
 import javax.inject.Inject;
 
 import java.util.List;
-import java.util.Map;
 
 import static com.facebook.presto.ml.type.ModelType.MODEL;
 import static com.facebook.presto.ml.type.RegressorType.REGRESSOR;
@@ -35,11 +34,6 @@ public class MLPlugin
 {
  private TypeManager typeManager;
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Inject
  public void setTypeManager(TypeManager typeManager)
  {

diff --git a/presto-spi/src/main/java/com/facebook/presto/spi/Plugin.java b/presto-spi/src/main/java/com/facebook/presto/spi/Plugin.java
@@ -18,7 +18,7 @@
 
 public interface Plugin
 {
- void setOptionalConfig(Map<String, String> optionalConfig);
+ default void setOptionalConfig(Map<String, String> optionalConfig) {}
 
  <T> List<T> getServices(Class<T> type);
 }
diff --git a/...nctions/src/main/java/com/facebook/presto/teradata/functions/TeradataFunctionsPlugin.java b/...nctions/src/main/java/com/facebook/presto/teradata/functions/TeradataFunctionsPlugin.java
@@ -19,8 +19,8 @@
 import com.google.common.collect.ImmutableList;
 
 import javax.inject.Inject;
+
 import java.util.List;
-import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -29,11 +29,6 @@ public class TeradataFunctionsPlugin
 {
  private TypeManager typeManager;
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Inject
  public void setTypeManager(TypeManager typeManager)
  {

diff --git a/presto-tests/src/main/java/com/facebook/presto/tests/tpch/IndexedTpchPlugin.java b/presto-tests/src/main/java/com/facebook/presto/tests/tpch/IndexedTpchPlugin.java
@@ -21,7 +21,6 @@
 import javax.inject.Inject;
 
 import java.util.List;
-import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -47,11 +46,6 @@ public void setNodeManager(NodeManager nodeManager)
  this.nodeManager = nodeManager;
  }
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Override
  public <T> List<T> getServices(Class<T> type)
  {

diff --git a/presto-tpch/src/main/java/com/facebook/presto/tpch/TpchPlugin.java b/presto-tpch/src/main/java/com/facebook/presto/tpch/TpchPlugin.java
@@ -21,7 +21,6 @@
 import javax.inject.Inject;
 
 import java.util.List;
-import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -36,11 +35,6 @@ public void setNodeManager(NodeManager nodeManager)
  this.nodeManager = nodeManager;
  }
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Override
  public <T> List<T> getServices(Class<T> type)
  {

diff --git a/presto-tpch/src/main/java/com/facebook/presto/tpch/testing/SampledTpchPlugin.java b/presto-tpch/src/main/java/com/facebook/presto/tpch/testing/SampledTpchPlugin.java
@@ -21,7 +21,6 @@
 import javax.inject.Inject;
 
 import java.util.List;
-import java.util.Map;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
@@ -36,11 +35,6 @@ public void setNodeManager(NodeManager nodeManager)
  this.nodeManager = nodeManager;
  }
 
- @Override
- public void setOptionalConfig(Map<String, String> optionalConfig)
- {
- }
-
  @Override
  public <T> List<T> getServices(Class<T> type)
  {