Fix Bad error message for invalid type

gerashegalov · Mar 2, 2015 · 5fa45a9 · 5fa45a9
1 parent a9537eb
commit 5fa45a9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/presto-main/src/main/java/com/facebook/presto/type/TypeRegistry.java b/presto-main/src/main/java/com/facebook/presto/type/TypeRegistry.java
@@ -122,7 +122,11 @@ private Type instantiateParametricType(TypeSignature signature)
  {
  ImmutableList.Builder<Type> parameterTypes = ImmutableList.builder();
  for (TypeSignature parameter : signature.getParameters()) {
- parameterTypes.add(getType(parameter));
+ Type parameterType = getType(parameter);
+ if (parameterType == null) {
+ return null;
+ }
+ parameterTypes.add(parameterType);
  }
 
  ParametricType parametricType = parametricTypes.get(signature.getBase().toLowerCase(Locale.ENGLISH));

diff --git a/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java b/presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java
@@ -3489,6 +3489,12 @@ public void testTypeMismatch()
  computeActual("SELECT 1 <> 'x'");
  }
 
+ @Test(expectedExceptions = RuntimeException.class, expectedExceptionsMessageRegExp = "\\QUnknown type: ARRAY<FOO>\\E")
+ public void testInvalidType()
+ {
+ computeActual("select cast(null as array<foo>)");
+ }
+
  @Test
  public void testTimeLiterals()
  throws Exception