Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 recommendation [GEOS-9619] #4428

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

jodygarnett
Copy link
Member

Taking discussion from #4243 into a pull request with concrete changes.

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for community modules):

  • There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (export to XML in Jira generates the message in this exact form)
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
  • Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates (screenshots, text)
  • Commits changing the REST API, or any configuration object, should check if the REST API docs (Swagger YAML files and classic documentation) need to be updated.

Signed-off-by: Jody Garnett <[email protected]>
@jodygarnett jodygarnett changed the title Java 8 recommendation Java 8 recommendation [GEOS-9619] Jul 21, 2020
Enable the Marlin rasterizer
----------------------------

Before Java 9, OpenJDK and Oracle used the Pisces and Ductus renderers to rasterize vector data respectively. In Java 9 onward they use Marlin which has better overall performance in most situations than either Pisces or Ductus.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this into on the prior page where it talks about java versions.

-
-
- tested
- GeoServer 2.2.x and earlier
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do not think anyone is working on Java 5 anymore this is much easier to read as a table

Running on Java 11
------------------
Running on Java 8 (Recommended)
-------------------------------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear recommendation of Java 8, provides a summary of the options, and then a heading to explore each idea.

@@ -196,3 +223,16 @@ Installing native JAI manually
You can install the native JAI manually if you encounter problems using the above installers, or if you wish to install the native JAI for more than one JDK/JRE.

Please refer to the `GeoTools page on JAI installation <http:https://docs.geotools.org/latest/userguide/build/install/jdk.html#java-extensions-optional>`_ for details.

Running on Java 11
------------------
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New heading for Java 11, provides a summary of options, this way it is very clear Java 11 works out of the box and does not have as many optional installs.


An IBM ID is needed to log in. The installation is identical to Oracle.
Native JAI and ImageIO extensions (not recommended)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear Java 8 subheading for Native JAI and ImageIO, and clearly not recommended.

I considered taking this section to the wiki and removing it from our day-to-day user manual.

Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just suggested a minor wording change.

@jodygarnett jodygarnett merged commit f0bc583 into geoserver:master Jul 29, 2020
@jodygarnett jodygarnett deleted the java8recommended branch July 29, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants