Fix computation of dynamic ratio colorbar min/max values in six_plot.py #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/plot/six_plot.py - Now set vmin as the min of the absolute values of the min and max of the plot_val array and set vmax as 1/vmin. - This should prevent the colorbar from being set to a too-narrow range. CHANGELOG.md - Updated accordingly.
msulprizio
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR fixes an issue with the computation of the dynamic range colorbar values. Under certain circumstances the colorbar range would be set to a narrower range than what the actual data showed. Case in point, this J-value plot at 500 hPa from the 14.5.0-alpha.17 vs. 14.4.3 GEOS-Chem benchmark plots.
Expected changes
With this fix, the dynamic range colorbar ratio is set to the proper range to capture the variation in the data.
