Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for GEOS-Chem Classic restart file path #160

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

msulprizio
Copy link
Contributor

GEOS-Chem Classic and GCHP restart files are now saved to a Restarts subdirectory.

This partially addresses issue #158, but as pointed out there it would be best to eventually specify the path in the configuration file.

GEOS-Chem Classic and GCHP restart files are now saved to a Restarts
subdirectory.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio msulprizio self-assigned this Sep 16, 2022
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple fix that changes "restarts" to "Restarts". A further fix to specify the path in the configuration file can be made later, but this fix is sufficient to allow benchmark plotting to proceed without errors.

@laestrada
Copy link
Contributor

Wouldn't this break backwards compatibility with GC?

@msulprizio
Copy link
Contributor Author

Wouldn't this break backwards compatibility with GC?

Yes. Is it worth adding a is_gcc_pre_14.0 variable like we do for GCHP? Seems overkill but I'm happy to do it if that's what makes sense until we add a path to the config file.

@laestrada
Copy link
Contributor

laestrada commented Sep 16, 2022

Wouldn't this break backwards compatibility with GC?

Yes. Is it worth adding a is_gcc_pre_14.0 variable like we do for GCHP? Seems overkill but I'm happy to do it if that's what makes sense until we add a path to the config file.

@msulprizio I think that it would otherwise cause the next few automated benchmark comparisons to fail because it would be looking for a Restarts/ directory in the ref version (eg. 14.0.1 vs 14.0.0), etc. I am happy to just implement the config file path sometime next week if that seems easier though.

@msulprizio
Copy link
Contributor Author

A switch has now been added for is_gcc_pre_14_0

@msulprizio msulprizio merged commit fc30e5b into dev Sep 21, 2022
@msulprizio msulprizio deleted the bugfix/gcc_restart_path branch September 21, 2022 13:49
@yantosca yantosca added this to the 1.3.2 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants