Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULL REQUEST] Remove duplicate Inst%FLUXSABI allocation in MEGAN HCO extension #70

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

jimmielin
Copy link
Collaborator

Hi GCST,

This is a minor fix sent to me from Thibaud Fritz from MIT (@fritzt). He wrote:

I found what seems to be a minor bug/typo in HEMCO Extensions. In hcox_megan_mod.F90, Inst%FLUXSABI seems to get allocated twice which I don't see a reason why this is the case.

ALLOCATE( Inst%FLUXSABI( NX, NY ), STAT=AS )
IF ( AS /= 0 ) THEN
CALL HCO_ERROR( HcoState%Config%Err, 'FLUXBPIN', RC )
RETURN
ENDIF
Inst%FLUXBPIN = 0.0_sp
ALLOCATE( Inst%FLUXSABI( NX, NY ), STAT=AS )
IF ( AS /= 0 ) THEN
CALL HCO_ERROR( HcoState%Config%Err, 'FLUXSABI', RC )
RETURN
ENDIF
Inst%FLUXSABI = 0.0_sp

This PR removes the duplicate allocation. Thanks!

@msulprizio msulprizio added the category: Bug Something isn't working label Mar 3, 2021
@msulprizio msulprizio added this to the 3.1.0 milestone Mar 3, 2021
@lizziel lizziel self-assigned this Mar 22, 2021
@lizziel lizziel changed the base branch from main to dev March 22, 2021 19:56
@lizziel lizziel merged commit d840f64 into geoschem:dev Mar 22, 2021
@msulprizio msulprizio modified the milestones: 3.1.0, 3.0.0 Jul 16, 2021
BettyCroft pushed a commit to BettyCroft/HEMCO that referenced this pull request May 24, 2022
…ctory creation

Also merge in a bug fix (PR geoschem#70) in HEMCO.

Signed-off-by: Melissa Sulprizio <[email protected]>
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants