Retire ExtState%WLI (land-water-ice index) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LWI is the land-water-ice index included in input meteorology. It is derived from fraction land types which are also available as input. It is therefore retired in favor of using the fractions which are already read into in HEMCO. Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
added
the
topic: Input Data
Signed-off-by: Lizzie Lundgren <[email protected]>
|
@christophkeller, this PR changes the subroutine |
|
Results of a 1-month GEOS-Chem benchmark comparison with and without this update show differences in the land/ocean/ice boundaries, as shown here: |
This was referenced Nov 4, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue. |
yantosca
added
never stale
yantosca
approved these changes
Dec 16, 2022
msulprizio
approved these changes
Jan 5, 2023
zmoon
added a commit
to noaa-oar-arl/NEXUS
that referenced
this pull request
Apr 26, 2023
This was removed for HEMCO v3.6 In geoschem/HEMCO#170 they just removed the relevant block from the standalone mod, as we do here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is 1 of 2 for super-projects. See instructions here:
geoschem/GCHP#264
geoschem/GCClassic#26
This pull request retires use of external meteorology field land-water-ice (LWI) index and the ExtState array it is stored in (
ExtState%WLI). We are removing it as a dependency because it will not be in the GEOS-IT dataset and determining whether a grid cell is over ocean, ice, or land is possible through other input meteorology fields, specifically GMAO meteorology constantsFRLAND,FRLANDIC,FRLAKE, andFROCEAN, and time-varying fieldsFRSEAICEandFRSNO.The
ExtState%WLIfield is currently used in HEMCO to retrieve land type via subroutineHCO_LANDTYPEinhco_geotools_mod.F90. That subroutine is called in the following extension modules, which will be impacted by this update:Note that the LWI input field used for WLI in HEMCO is currently computed during GEOS-Chem input pre-processing from the other GMAO surface type met-fields. Changing to using these fields at run-time will result in differences in the model. In addition, the new way for determining if mostly land, ice, or ocean is to evaluate which surface type fraction is the greatest. This is a slightly different algorithm than what was used to compute LWI and this will also cause small differences.
There is an accompanying pull request in GEOS-Chem that should be merged at the same time:
geoschem/geos-chem#1435.