Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Issue in HEMCO standalone following retiring of carbon-based units #64

Closed
msulprizio opened this issue Nov 23, 2020 · 1 comment
Assignees
Labels
category: Bug Something isn't working

Comments

@msulprizio
Copy link
Contributor

@hongjianweng wrote:

When I use HEMCO-standalone dev/13.0.0,
HEMCO_sa_Spec.rc has removed emMW_g and MolecRatio
#ID NAME MW K0 CR PKA

but I found the SUBROUTINE Model_GetSpecies in hcoi_standalone_mod.F90 still read them

901 ! Read species ID, name, molecular weight, and Henry coefficients
902 ! K0, CR, pKa (in this order).
903 DO I = 1, 8
904
905 ! Get lower and upper index of species ID (first entry in row).
906 ! Skip all leading spaces.
907 UPP = LOW
908
909 DO WHILE( UPP == LOW .AND. LOW /= LNG )
910 LOW = LOW + 1
911 IF ( LOW > LNG ) THEN
912 WRITE(MSG,101) I, TRIM(DUM)
913 CALL HCO_Error( MSG, RC, THISLOC=LOC )
914 RETURN
915 ENDIF
916 UPP = NextCharPos( TRIM(DUM), HCO_SPC, LOW )
917 IF ( UPP < 0 ) UPP = LNG
918 ENDDO

The conflicting settings will cause errors in calculating emissions using hemco_standalone:
forrtl: severe (24): end-of-file during read, unit -5, file Internal List-Directed Read

HEMCO_Spec.rc.txt
hcoi_standalone_mod.F90.txt

So has hcoi_standalone_mod.F90 not been fix yet for retiring carbon-based units for VOCs?
Besides, should I offer species-based units offline emissions when no further use carbon-based in v13.0.0 and later version?

@msulprizio
Copy link
Contributor Author

This is now resolved in commit 880dec3 and will be included in the GEOS-Chem 13.0.0 / HEMCO 3.0.0 release.

BettyCroft pushed a commit to BettyCroft/HEMCO that referenced this issue May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant