Process manager generate job ids #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test reported by CI seems to be unrelated to my changes - I've tracked it down to this failed request Indeed demo.mapserver.org is returning |
|
Yes MapServer demo is temporarily down due to upgrades, see also: |
tomkralidis
requested changes
Apr 11, 2023
pygeoapi/process/manager/base.py
Outdated
| @@ -27,9 +27,10 @@ | |||
| # | |||
| # ================================================================= | |||
|
|
|||
| from datetime import datetime | |||
There was a problem hiding this comment.
Can we keep the order of imports:
- standard library (alphabetical order)
- blank line
- 3rd party imports (PyPI) (alphabetical order)
- blank line
- local imports (alphabetical order)
There was a problem hiding this comment.
I thought this was in line with keeping the order?
I usually put from imports below straight ones because it is also how isort and other tools do it, and because it is sorted alphabetically. Anyway, no biggie I'll switch it up 😉
pygeoapi/process/manager/dummy.py
Outdated
| @@ -28,6 +28,7 @@ | |||
| # ================================================================= | |||
|
|
|||
| import logging | |||
| import uuid | |||
There was a problem hiding this comment.
Same comment here, RE: import ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modifies the pygeoapi process manager to be responsible for generating job ids, as discussed in #1207.
The proposed implementation simply makes the generation of a job's id part of the process manager's set of responsabilities, which means that the job id is now returned from the process manager's
execute_process()method, rather than it being an input to this method.Related Issue / Discussion
Contributions and Licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)